Add tests for table trace type with Plotly.restyle and Plotly.relayout #2096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Oct 17, 2017
test/jasmine/tests/table_test.js
Outdated
| } | ||
|
|
||
| it('should be able switch to table trace from another plot type', function(done) { | ||
| var mock = Lib.extendDeep({}, require('@mocks/workspace_starter_state.json')); |
There was a problem hiding this comment.
@VeraZab would you mind replacing this require call with:
var mock = {
data: //
layout //
}as each json mock in test/image/mocks/ is expected to have a corresponding image in test/image/baselines/? This should make the test go ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #2092
I've written a few sample tests for what would be needed to properly integrate tables in the workspace, let me know if there's any questions or anything else I can help with
cc @monfera